-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix type error #27
Fix type error #27
Conversation
Looks like there's another error from some previous PR:
No error on my machine though |
Did i break anything? Looks like you reverted the error change from two days ago. The tests on that were green. Im also getting the AllEvents[number] error locally. I can try debug it. |
Yeah somehow the tests are more permissive than Previously this error would only have surfaced in the release CI which runs |
If you revert the error change it will only work for "@solana/web3.js": "<1.92.0" for "@solana/web3.js": ">1.92.0" the parameter needs to be an object. Thats why I updated the package.json file. Maybe you need to run yarn install locally for it to work? |
Ah right yeah maybe that's it lol Will check later |
The other IDL error seems to come from anchor directly. Only way i found to make the build work is ignoring it with Maybe you have more luck |
263b34c
to
6b0295a
Compare
I can confirm #25 did not break anything, sorry for jumping the gun lol |
Did you figure out what the other Events error comes from? I couldnt figure it out sadly. |
I decided skipLibCheck is good enough for me |
Fixes error from #25 and adds
tsc
to lint script so this doesn't happen again